Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Crash in Scan Runner.rb #21997

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cpisciotta
Copy link

@cpisciotta cpisciotta commented May 1, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Resolves a crash when Scan.devices is nil.

Description

Similar to the lines above it, check if Scan.devices is non-nil before iterating over its values.

Testing Steps

@cpisciotta cpisciotta marked this pull request as ready for review May 1, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant