Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if a tester is already added to the desired group(s) #188

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

phaseOne
Copy link
Contributor

@phaseOne phaseOne commented Nov 18, 2017

Right now, boarding will display an error message if a tester is already added to an app, but not part of a group yet. In addition, invites are not resent, if the tester is already added to the group.

This PR is a work in progress to resolve these issues.

Tasks

  • Display the new and old groups to which a tester is added
  • Resend the TestFlight invite if the user has not yet accepted the invite, and display a message
  • Optimization: only add the tester to groups that the tester is not yet a part of

Addresses

@kdawgwilk
Copy link

I thought I had posted on the other issue that I tested things out but it appears I forgot to send it :( But this PR looks like it will solve the only issue I was experiencing (pretty minor). The issue was with existing users not belonging to the group they are trying to be added to. Thanks for the hard work to get this fixed 👍

@joshdholtz
Copy link
Member

@phaseOne This PR sounds like it would be a great addition. Are you still working on this? 🙃

@phaseOne phaseOne mentioned this pull request Jul 2, 2018
@FinHorsley
Copy link
Contributor

Please can the merge conflicts be resolved, and this PR accepted, as this solves the same problems that we have been seeing

@phaseOne
Copy link
Contributor Author

phaseOne commented Mar 1, 2019

Anyone else able to take this on? Slammed at the office right now

@FinHorsley
Copy link
Contributor

@phaseOne Apart from the merge conflict, is there anything else that is preventing this PR from being accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants