Modify EmbeddingDropout and adapt AWD_LSTM to trigger hooks in Embedding layers #2906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #2850
@sutt already fixed the
awd_lstm.WeightDropout
class to be able to run the ActivationStats callback for the model AWD_LSTM. Still the Embedding layers were not recording any statistics. Furthermore the Hooks class had duplicated layers due to howflatten_model
works.In this PR I propose a modification to solve both issues:
An example of this can be found here: example EmbeddingDropout.
To solve the issue I just modified slightly the class
EmbeddingDropout
and adaptedAWD_LSTM
to work exactly the same as before for these changes. I think now the code is more compact than before.I by no means have your expertise, nevertheless I tried to do my best refactoring the code. If there is anything that I did wrong just let me know.
Thanks a lot!