-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity layout and minor UI changes #832
base: 3.x
Are you sure you want to change the base?
Conversation
/* Hide layout regions if there is no content. */ | ||
.layout--twocol .layout__region:not(:has(div)){ | ||
display: none; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seemed to be caused by an empty <div>
that seems like it would have displayed error/warning messages but it didn't render any and I haven't been able to reproduce. I was in-between switching branches and clearing cache so it's possible it was a fluke but I do wonder if this is an issue.
I will try and get some more screenshots (mobile!) with more data on these pages. Most notably log quantities and files that are attached to the page. |
A couple more screenshots with more data... definitely a few things to clean up, but the mobile LGTM! Anyone have thoughts on the below? @mstenta @Farmer-Eds-Shed @Fosten @symbioquine
|
My original motivation for this was to improve the display of the "Add new comment" field on entities. Ultimately I think the best solution is to make each of our layout regions use the "gin-layer-wrapper" styles so they get a background color/shadow and are lifted on the page to match the existing comment styles. Then decreasing the size of the comment text headers (h2 is pretty big) makes things look nice.
Last, some minor changes to make other css in farm_ui_theme consistent.