Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SAML user does not exist logging call #185

Open
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

jpmanthorp
Copy link

Caused by how we did not use Python's old string formatting operator to inject the problematic id into the log message. This issue caused one of our SAML logging calls to raise its own error last week and consequently the "user not found error" percolated up to a user instead of redirecting them to a denied page. For the sake of clarity, we will now manually format the string injected into the logger (as opposed to allowing the logging module to only generate the final msg if the log would actually be produced) as this is a fairly inexpensive operation.

See logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants