Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Relay State): Use relay state param for redirection after login #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Oct 1, 2019

Overview

Pass next_url as relay param to prepare_to_authenticate which is echoed back as IDP response and can be accessed in POST request from IDP along with SAML RESPONSE.

Assign next url to relay state param if defined else consider previous next_url var

@cguethle
Copy link

cguethle commented Oct 2, 2019

Much better than my solution. Hopefully @fangli merges this and publishes a new patch version.

@ntravis
Copy link

ntravis commented Oct 24, 2019

We're also being hit by this, and would be quite happy to see it get merged in! @fangli do you have any objections to this as a fix to behavior?

@ntravis
Copy link

ntravis commented Jan 1, 2020

@fangli any reason not to merge?

@ecararus
Copy link

ecararus commented Apr 8, 2020

Hello Amit
Can this issue be closed?

@amit17051980
Copy link

Hello Amit
Can this issue be closed?

Yes @ecararus. Awaiting @fangli to merge the same. :)

nickdnickd added a commit to nickdnickd/django-saml2-auth that referenced this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants