Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: update(OWNERS): add therealbobo (Roberto Scolaro) to approvers #72

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

therealbobo
Copy link
Collaborator

@therealbobo therealbobo commented Sep 13, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Proposing myself as kernel-testing maintainer (as per 2023-09-13 community call discussion) and continue supporting the project in the following main areas:

  • image maintenance/creation
  • code reviews + bug fixes

@poiana
Copy link

poiana commented Sep 13, 2023

@therealbobo: The label(s) kind/documentation cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Proposing myself as kernel-testing maintainer (as per 2023-09-13 community call discussion) and continue supporting the project in the following main areas:

  • image maintenance/creation
  • code reviews + bug fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP
Copy link
Collaborator

FedeDP commented Sep 14, 2023

Big +1 from me! Roby was the king of generating docker images, and made such a terrific job in that area!
Thank you very much, happy to see you on board!

@Andreagit97
Copy link
Member

Big +1 for me!

Copy link
Collaborator

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Oct 11, 2023

LGTM label has been added.

Git tree hash: e828131804ea276a19feb87dce65e2d6f2446936

@poiana
Copy link

poiana commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Collaborator

FedeDP commented Oct 11, 2023

/hold

@FedeDP
Copy link
Collaborator

FedeDP commented Oct 11, 2023

We need test-infra and evolution PRs !

@leogr
Copy link
Member

leogr commented Oct 12, 2023

/verify-owners
/hold cancel

@poiana poiana merged commit 70b7acc into falcosecurity:main Oct 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants