infra(unicorn): prefer-at #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
p: 1-normal
Shinigami92
force-pushed
the
infra/unicorn/prefer-at
branch
from
2f1f109
to
346d52b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #2654 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 2817 2817
Lines 251202 251203 +1
Branches 1123 1126 +3
=======================================
+ Hits 250090 250096 +6
+ Misses 1083 1078 -5
Partials 29 29
|
Shinigami92
commented
Feb 9, 2024
ST-DDT
previously approved these changes
Feb 9, 2024
|
IMO this isn't breaking for the same reasons as outlined there: #2653 (comment) |
matthewmayer
previously requested changes
Feb 10, 2024
ST-DDT
requested changes
Feb 10, 2024
ST-DDT
previously approved these changes
Feb 16, 2024
ST-DDT
reviewed
Feb 16, 2024
|
|
||
| Used Node >= v16.6 feature [`at`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at). | ||
|
|
||
| We could hint users to use polyfill or transpile-down steps. |
There was a problem hiding this comment.
Note from my future me: We will have at most a very minimum description of "how to transpile down for node < x". I won't help them shoot themselves in the foot and complain to us about it.
And I won't keep track of any node <18 feature usage myself unless specifically requested by our community.
There was a problem hiding this comment.
If you are stuck using node 14/16 you should just stay on faker@8 rather than try to transpile things.
import-brain
previously approved these changes
Feb 17, 2024
Shinigami92
dismissed stale reviews from import-brain and ST-DDT
via
3458af5
ST-DDT
approved these changes
Feb 19, 2024
Shinigami92
dismissed
matthewmayer’s stale review
The requested changes were already resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2439
Permanently enables the
unicorn/prefer-atlint rule.