Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curves #266

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Curves #266

wants to merge 15 commits into from

Conversation

jakubDoka
Copy link

This commit adds beizer curves to geometry and also adds one method for vector Angle to. Its all documentated. Curve should be used by a particle system i am planing to pull request.

@bcvery1
Copy link
Contributor

bcvery1 commented Nov 4, 2020

Why no tests?

Not sure why you're returning a pointer for B, Linear or Constant and why you have a pointer receiver for Point, the rest of the file is entirely functional with no pointer returns or receivers

@jakubDoka
Copy link
Author

Ok i ll make some test just for sake of it. Lets remove these pointers then.

Copy link
Collaborator

@dusk125 dusk125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Bezier functions/structures look good, was there a reason why you needed to change the pixelgl.Window structure to directly embed the glfh.Window structure?

@dusk125
Copy link
Collaborator

dusk125 commented Aug 31, 2021

The Bezier functions/structures look good, was there a reason why you needed to change the pixelgl.Window structure to directly embed the glfh.Window structure?

@jakubDoka

@duysqubix
Copy link
Contributor

@dusk125

I assume this PR is not relevant anymore.

@dusk125
Copy link
Collaborator

dusk125 commented Oct 4, 2023

@duysqubix could still be useful, I would suggest we revert the window.go changes. But other than those, lgtm

@duysqubix
Copy link
Contributor

duysqubix commented Oct 4, 2023

@dusk125

I am going to recreate this PR in pixel2 to track and modify changes there.

Update:
PR merged with Pixel2

@duysqubix duysqubix mentioned this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants