This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Use requestAnimationFrame's build in high precision timestamp #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requestAnimationFrame passes back a high.precision timestamp which is far more accurate than ```Date.now()``` Switch to this to improve animations smoothness and accuracy.
|
Yeap! here's the related discussion: jquery/jquery#3143 |
wbinnssmith
pushed a commit
that referenced
this pull request
Feb 28, 2018
This uses performance.now (or a fallback to Date.now in environments without it) to provide a more accurate measurement of time while animating, which should result in smoother animations. Deliberately use this rather than using `requestAnimationFrame`'s callback's argument as it can sometimes misrepresent the current time. [See its use in velocity](https://github.com/julianshapiro/velocity/blob/92f6981723e51895855812366739a04fef93176b/src/Velocity/tick.ts#L158-L160). Supercedes #22.
wbinnssmith
pushed a commit
that referenced
this pull request
Feb 28, 2018
This uses performance.now (or a fallback to Date.now in environments without it) to provide a more accurate measurement of time while animating, which should result in smoother animations. Deliberately use this rather than using `requestAnimationFrame`'s callback's argument as it can sometimes misrepresent the current time. [See its use in velocity](https://github.com/julianshapiro/velocity/blob/92f6981723e51895855812366739a04fef93176b/src/Velocity/tick.ts#L158-L160). Supercedes #22.
|
This is resolved by #47 🎉 thanks for your motivation and your patch :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestAnimationFrame passes back a high.precision timestamp which is far more accurate than
Date.now()Switch to this to improve animations smoothness and accuracy.