handle closed listeners #14
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
gracenet/net.go
Outdated
| files[i], err = l.(filer).File() | ||
| files := make([]*os.File, 0, len(listeners)-len(closedList)) | ||
| for _, l := range listeners { | ||
| is_closed := false |
There was a problem hiding this comment.
Use go like naming, ie isClosed.
|
I think this looks good but would like to see tests (as hard as they are to write due to the nature of this package). |
|
I think the test is hard in the package, however it could be done with an external test tool. |
|
Look at the existing tests - I think it should be possible to write some without having to use an external tool. |
|
Any news about this? I would definitely love to use that feature. |
|
I have no idea about this tell me now solher |
Merge 'master' of github.com/facebookgo/grace and support gracehttp.ServeWithNet
Merge 'master' of github.com/facebookgo/grace and support gracehttp.ServeWithNet
| @@ -9,7 +9,7 @@ import ( | |||
| "os" | |||
| "time" | |||
|
|
|||
| "github.com/facebookgo/grace/gracehttp" | |||
| "github.com/absolute8511/grace/gracehttp" | |||
There was a problem hiding this comment.
This was probably flipped for testing, but we should undo this before merging here.
Add the close interface for listener and check the closed while restart.