Support ref cleanup function for imperative handle refs #28910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: cf5ab8b...964ca88 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
should these double-invoke in StrictMode too then? would it be worth adding a test for an imperative ref in the StrictMode tests? https://github.com/facebook/react/blob/main/packages/react-reconciler/src/__tests__/StrictEffectsModeDefaults-test.internal.js#L411 maybe "DOM refs" isn't the best terminology for me to use in reactjs/react.dev#6777 – it doesn't seem like that encompasses imperative handle refs clearly |
acdlite
approved these changes
Apr 25, 2024
eps1lon
approved these changes
Apr 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Support ref cleanup function for imperative handle refs DiffTrain build for commit ed71a3a.
|
@noahlemen Additional StrictMode test would be nice. It "just" works already: https://codesandbox.io/p/sandbox/ref-cleanups-forked-ccp74m?file=%2Fsrc%2Findex.js%3A35%2C46 |
bigfootjon
pushed a commit
that referenced
this pull request
Apr 25, 2024
Support ref cleanup function for imperative handle refs DiffTrain build for commit ed71a3a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ref cleanup function for imperative handle refs