Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate references to deprecated UIActivityIndicatorViewStyles #44428

Closed
wants to merge 1 commit into from
Closed

Migrate references to deprecated UIActivityIndicatorViewStyles #44428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/Wrapper/Example/RCTWrapperReactRootViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ - (void)loadView
rootView.backgroundColor = [UIColor whiteColor];

UIActivityIndicatorView *progressIndicatorView =
[[UIActivityIndicatorView alloc] initWithActivityIndicatorStyle:UIActivityIndicatorViewStyleWhiteLarge];
[[UIActivityIndicatorView alloc] initWithActivityIndicatorStyle:UIActivityIndicatorViewStyleLarge];
[progressIndicatorView startAnimating];
rootView.loadingView = progressIndicatorView;

Expand Down
3 changes: 0 additions & 3 deletions packages/react-native/React/Views/RCTActivityIndicatorViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@

@implementation RCTConvert (UIActivityIndicatorView)

// NOTE: It's pointless to support UIActivityIndicatorViewStyleGray
// as we can set the color to any arbitrary value that we want to

RCT_ENUM_CONVERTER(
UIActivityIndicatorViewStyle,
(@{
Expand Down