Fix HermesExecutorFactory build error #44423
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
7af288e5 introduced a breaking change for whoever importing HermesExecutorFactory.h, because the
hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.h
is not a public header. Also the nested import is not ideal for CocoaPods or use_frameworks.I think HermesRuntimeTargetDelegate could be an implementation detail that hide from header. This PR tries to turn the ownership declaration from std::optional to std::unique_ptr, so that we could hide the concrete type.
Changelog:
[IOS] [FIXED] - Fixed
HermesExecutorFactory.h
build error when importing its private headerTest Plan:
should introduce no breaking change and ci passed