Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HermesExecutorFactory build error #44423

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented May 6, 2024

Summary:

7af288e5 introduced a breaking change for whoever importing HermesExecutorFactory.h, because the hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.h is not a public header. Also the nested import is not ideal for CocoaPods or use_frameworks.
I think HermesRuntimeTargetDelegate could be an implementation detail that hide from header. This PR tries to turn the ownership declaration from std::optional to std::unique_ptr, so that we could hide the concrete type.

Changelog:

[IOS] [FIXED] - Fixed HermesExecutorFactory.h build error when importing its private header

Test Plan:

should introduce no breaking change and ci passed

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner labels May 6, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,284 -1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,602 -5
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 362abb9
Branch: main

@Kudo Kudo marked this pull request as ready for review May 6, 2024 14:20
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label May 6, 2024
@facebook-github-bot
Copy link
Contributor

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 7, 2024
@facebook-github-bot
Copy link
Contributor

@huntie merged this pull request in 2d46dbe.

Copy link

github-actions bot commented May 7, 2024

This pull request was successfully merged by @Kudo in 2d46dbe.

When will my fix make it into a release? | How to file a pick request?

@Kudo Kudo deleted the @kudo/rn075/fix-hermes-executor-factory-build-error branch May 7, 2024 10:32
@Kudo
Copy link
Contributor Author

Kudo commented May 7, 2024

thanks for merging the fix 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants