fix: TextInput selectionColor props on iOS
#44420
Closed
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NickGerleman looks like the |
|
In which version will this PR be released? ....Concern. |
|
@NickGerleman merged this pull request in 2bde626. |
|
This pull request was successfully merged by @robinshin in 2bde626. When will my fix make it into a release? | How to file a pick request? |
|
Posted a cherry-pick request so it can be included in the next 0.74 patch release. |
janicduplessis
pushed a commit
to janicduplessis/react-native
that referenced
this pull request
May 18, 2024
Summary: This pull request fixes an issue where the `selectionColor` prop was not applied to the `TextInput` component on iOS, starting from React Native version 0.74.x. This issue was introduced in PR [1e68e48](facebook@1e68e48#diff-b6634353ea5b10a91de24605dc51bdfb50e8ddb652ccd5b9dab194168a69d4b1) which relocated `selectionColor` along with `selectionHandleColor` and `cursorColor` out of `otherProps`. This modification inadvertently prevented `selectionColor` from being passed to the iOS native component. This change ensures that the `selectionColor` prop is explicitly included in the `RCTTextInputView` component's properties, fixing the regression. Note: `selectionHandleColor` and `cursorColor` are Android-specific and do not require explicit passing on iOS. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS] [FIXED] - Fixed an issue where the `selectionColor` prop was not being applied on the `TextInput` component. Pull Request resolved: facebook#44420 Test Plan: **Environment:** iOS Simulator, React Native 0.74.0. **Steps to reproduce:** - Implement a `TextInput` component with the `selectionColor` prop set. - Run the application on an iOS device or simulator. - Focus on the TextInput component, write some text and select it. **Expected Result:** the selection color should match the color provided to the `selectionColor` prop. **Actual result before fix:** the selection color did not reflect the specified `selectionColor` prop and fell back to the default iOS selection color (blue). **Screenshots:** - Before fix: <img width="1710" alt="before_fix" src="https://github.com/facebook/react-native/assets/17989553/8660068c-55c9-4f55-a788-f96eb681fb70"> - After fix: <img width="1710" alt="after_fix" src="https://github.com/facebook/react-native/assets/17989553/93c9eb26-7da0-4957-b54f-8444aff7e374"> Reviewed By: javache Differential Revision: D57017836 Pulled By: NickGerleman fbshipit-source-id: 263ce22168e09c15cdfdb4eb4300a2605d8af032
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request fixes an issue where the
selectionColorprop was not applied to theTextInputcomponent on iOS, starting from React Native version 0.74.x.This issue was introduced in PR 1e68e485 which relocated
selectionColoralong withselectionHandleColorandcursorColorout ofotherProps. This modification inadvertently preventedselectionColorfrom being passed to the iOS native component.This change ensures that the
selectionColorprop is explicitly included in theRCTTextInputViewcomponent's properties, fixing the regression.Note:
selectionHandleColorandcursorColorare Android-specific and do not require explicit passing on iOS.Changelog:
[IOS] [FIXED] - Fixed an issue where the
selectionColorprop was not being applied on theTextInputcomponent.Test Plan:
Environment: iOS Simulator, React Native 0.74.0.
Steps to reproduce:
TextInputcomponent with theselectionColorprop set.Expected Result: the selection color should match the color provided to the
selectionColorprop.Actual result before fix: the selection color did not reflect the specified
selectionColorprop and fell back to the default iOS selection color (blue).Screenshots: