TextInput - selection
prop is not set on component creation
#44398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Problem:
selection
prop is not being set on component creation.Not quite sure which RN version this issue was introduced but fixing it on latest code.
Use playground for testing (refer to following diff)
Proposed Solution:
Added notes in comments but
viewCommands.setTextAndSelection()
is called only on text or selection update which relies on comparing data withlastNativeSelection
. Problem is thatlastNativeSelection
is initially set to the props value that is passed in so does not send the command on component creation.So assign a default selection value of
{start: -1, end: -1}
so it can be set on component creation.Changelog:
[General][Fixed] - 'selection
prop in
TextInput` was not being applied at component creationDifferential Revision: D56911712