New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<ScrollView/>: Add static ViewConfig for maintainVisibleContentPosition #44374
Open
RSNara
wants to merge
9
commits into
facebook:main
Choose a base branch
from
RSNara:export-D56854757
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
May 2, 2024
This pull request was exported from Phabricator. Differential Revision: D56854757 |
This pull request was exported from Phabricator. Differential Revision: D56854757 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
May 2, 2024
…on (facebook#44374) Summary: Pull Request resolved: facebook#44374 This prop was introduced for horizontal and vertical scrollview in D40642469. That diff updated the native view configs only. **Note:** This prop does not work for bridgeless mode. Partial fix: Add the prop to vertical scrollview: D54223244 Full fix: this diff. Changelog: [Internal] Reviewed By: javache Differential Revision: D56854757
This pull request was exported from Phabricator. Differential Revision: D56854757 |
Base commit: 185f63b |
Summary: Changelog: [Internal] Differential Revision: D56831755 Reviewed By: javache
Summary: experimental_layoutConformance was added in this diff: D47940100 Changelog: [Internal] Differential Revision: D56849869
Summary: collapsableChildren was introduced in D56226241 Changelog: [Internal] Differential Revision: D56849868
Summary: onClick was made into a capture event in this diff: D45745906 - Partial fix: D51551255 - Full fix: this diff. **Note:** This prop did not work for bridgeless mode. Changelog: [Internal] Differential Revision: D56849867 Reviewed By: javache
Summary: The insets props were introduced in this diff: D42193661 Changelog: [Internal] Differential Revision: D56849870
Summary: The margin/padding props were introduced in this diff: D41267765 Changelog: [Internal] Differential Revision: D56846578
Summary: <Image/>'s source prop was introduced in D51479305. Changelog: [Internal] Differential Revision: D56831756 Reviewed By: javache
Summary: horizontal was introduced here: D55367445 Changelog: [Internal] Differential Revision: D56831754 Reviewed By: javache
Summary: This prop was introduced for horizontal and vertical scrollview in D40642469. That diff updated the native view configs only. **Note:** This prop did not work for bridgeless mode. Partial fix: Add the prop to vertical scrollview: D54223244 Full fix: this diff. Changelog: [Internal] Reviewed By: javache Differential Revision: D56854757
This pull request was exported from Phabricator. Differential Revision: D56854757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This prop was introduced for horizontal and vertical scrollview in D40642469.
That diff updated the native view configs only.
Note: This prop does not work for bridgeless mode.
Partial fix: Add the prop to vertical scrollview: D54223244
Full fix: this diff.
Changelog: [Internal]
Reviewed By: javache
Differential Revision: D56854757