Run GitHub Actions tests on current versions of Python #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2024
This was referenced Apr 24, 2024
|
@migeed-z has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Perhaps PyPy should be moved to a separate pull request because that GitHub Action test has been running for 3+ hours. |
cclauss
commented
Apr 24, 2024
|
@migeed-z has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
…833) Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` ```diff repos: - repo: https://github.com/pycqa/flake8 - rev: 4.0.1 + rev: 7.0.0 hooks: - id: flake8 ``` As discussed at: * PyCQA/flake8#1701 Pull Request resolved: #833 Test Plan: For test failures on Python < 3.10 see: * #832 Reviewed By: grievejia Differential Revision: D56535569 Pulled By: migeed-z fbshipit-source-id: 576cccafeca06e6ebe1290bcd115c53e4a07fbc2
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Related to:
PEP 604 – Allow writing union types as
X | Y-- https://peps.python.org/pep-0604On Python < 3.10 the tests are failing on PEP 604 type annotations which will be enforced by
ruff rule UP007.On Python < 3.10 the source file must start with
from __future__ import annotationsto be able to use PEP 604 syntax.Test Plan