Added paramikos's callbacks for sftp get and put operations based on:…

[martinwittmann]

Adding support for paramiko's callbacks for paramiko's put + get operations, which is based on #2044

The changes are trivial and could end several github issues and pull requests.

Here's a quick list:

• Added support for Paramiko SFTP callbacks #2044
• https://stackoverflow.com/questions/16578368/fabric-directory-copy-with-status-of-copying
• Adding a progress callback to fabric.operations.put() #394
• Add download/upload information for operations get/put #236

[martinwittmann]

Looks like the builds are failing randomly (e.g. https://travis-ci.org/github/fabric/fabric/jobs/774254250).
Could somebody be so kind and give me a hint what to do about the failing builds?

[davidjmemmett]

Hi @martinwittmann,

Thanks for the PR!
The Travis CI is due to be replaced with Circle CI soon, so please don't worry about the failed builds. I've checked out your branch and confirmed that the tests pass as-is.

A couple of issues that may hinder these changes being merged in:

• Tests that prove existing functionality isn't broken
• Tests to support the code you've added
• An entry in the changelog describing the change

I'd suggest adding at least one new test which passes a callback in, and verifies that it is called.

Cheers,
David

[martinwittmann]

I added a test + updated the changelog.
But I can't get any tests to run locally. I used https://docs.fabfile.org/en/1.12.1/running_tests.html to set everything up, but when running

nosetest tests/

I get "Ran 0 tests in 0.000s", and running fab test complains that it can't find a collection named fabfile.

It seems like I'm missing something.
Thanks for any pointers that might help get those test running!

[davidjmemmett]

I think you’re looking at the old docs for v1, try `inv test` :) Cheers, David

…

On 24 Jun 2021, at 18:36, Martin Wittmann ***@***.***> wrote:  I added a test + updated the changelog. But I can't get any tests to run locally. I used https://docs.fabfile.org/en/1.12.1/running_tests.html to set everything up, but when running nosetest tests/ I get "Ran 0 tests in 0.000s", and running fab test complains that it can't find a collection named fabfile. It seems like I'm missing something. Thanks for any pointers that might help get those test running! — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[martinwittmann]

Thanks a lot David for helping me out!
I added 2 integration tests for get and put operations verifying that the callbacks are actually being called.

If there is anything else that needs to be done to get this merged please let me know.

[martinwittmann]

@davidjmemmett Is there anything I can do to get this merged?

[davidjmemmett]

One for @bitprophet - I don't have merging permissions