SPDLOG-like logging in SGX #681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
requested changes
Oct 12, 2022
| // For code outside SGX enclaves we use spdlog macros for logging. We provide | ||
| // similar macros for logging (only in debug mode) from inside the enclave. Note | ||
| // that this logging is very costly as it does an ocall to print the message, | ||
| // as a consequence we no-op it at compile time for release builds |
There was a problem hiding this comment.
It took me a while to work out that we no-op ocallLogDebug, and not the SPDLOG_ macros here. Do we still call snprintf even in release builds? I would have expected:
#ifdef FAASM_SGX_DEBUG
#define SPDLOG_DEBUG_SGX(...)
size_t __bufferSize = 512;
...
#else
#define SPDLOG_DEBUG_SGX(...)
// No-op
#endif
| "Caught WASM runtime exception: " + errorMessage; | ||
| ocallLogError(errorText.c_str()); | ||
| SPDLOG_ERROR_SGX("Caught WASM runtime exception: %s", | ||
| errorMessage.c_str()); |
There was a problem hiding this comment.
I thought that spdlog formatting used {} not printf-style %s. Does this work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.