Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double backslashes from file path when opening unsupported files. #1428

Merged
merged 4 commits into from
May 21, 2024

Conversation

shambhupatil
Copy link
Contributor

Closes #1014

@shambhupatil
Copy link
Contributor Author

I think CIs are failing because the file path should be displayed in quotes.

@snoyer
Copy link
Contributor

snoyer commented May 18, 2024

I think CIs are failing because the file path should be displayed in quotes.

Looks like it, yes. The failing test

1/1 Test #429: f3d::TestUnsupportedFileText .....***Failed  Required regular expression not found. Regex=[.*unsupportedFile.dummy" is not a file of a supported file format

is defined here:

f3d_test(NAME TestUnsupportedFileText DATA unsupportedFile.dummy ARGS --filename REGEXP ".*unsupportedFile.dummy\" is not a file of a supported file format" NO_RENDER)

You'll have to either:

  • change the code to output the quotes
  • change the test to not expect the quotes

I can't tell you which one is the way to go but @mwestphal and @Meakk will

@mwestphal
Copy link
Contributor

You need to update the test, but it's a bit unclear to me where the quote was coming from in the first place.

@shambhupatil
Copy link
Contributor Author

Okay, I will look into why the quotes were there. Could you tell me how to update the tests?

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (6133d0f) to head (5b3a651).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1428   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         103      103           
  Lines        7679     7679           
=======================================
  Hits         7416     7416           
  Misses        263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal merged commit 3b49701 into f3d-app:master May 21, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path contains double backslashes in the Windows log window
3 participants