Backface Culling Additions #1421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
reviewed
May 6, 2024
Added command line for backface culling at "ConfigurationOptions::GetOptions"
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
- Coverage 96.55% 96.51% -0.05%
==========================================
Files 103 103
Lines 7555 7570 +15
==========================================
+ Hits 7295 7306 +11
- Misses 260 264 +4 ☔ View full report in Codecov by Sentry. |
…x/.h -Added `SetUseBackface` call in window_impl.cxx -Modified command name for backface culling in `options.cxx` and `F3DOptionsParser.cxx` -Changed attribute name for backface to `UseBackface`
mwestphal
reviewed
May 25, 2024
| @@ -345,6 +345,7 @@ void ConfigurationOptions::GetOptions(F3DAppOptions& appOptions, f3d::options& o | |||
| this->DeclareOption(grp2, "point-type", "", "Point sprites type when showing point sprites", options.getAsStringRef("model.point-sprites.type"), HasDefault::YES, MayHaveConfig::YES, "<sphere|gaussian>"); | |||
| this->DeclareOption(grp2, "point-size", "", "Point size when showing vertices or point sprites", options.getAsDoubleRef("render.point-size"), HasDefault::YES, MayHaveConfig::YES, "<size>"); | |||
| this->DeclareOption(grp2, "line-width", "", "Line width when showing edges", options.getAsDoubleRef("render.line-width"), HasDefault::YES, MayHaveConfig::YES, "<width>"); | |||
| this->DeclareOption(grp2, "backface", "", "Backface default (visible) or hidden", options.getAsStringRef("render.backface"), HasDefault::YES, MayHaveConfig::YES, "<default|hidden>"); | |||
There was a problem hiding this comment.
I still think default should be unchanged.
possible value:
- default
- visible
- hidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "SetBackfaceCulling()" at "vtkF3DRenderer::ConfigureActorsProperties()".
Added "BackfaceCullingVisible" in class "vtkF3DRenderer".
Added CheatSheet text at "vtkF3DRenderer::FillCheatSheetHotkeys" for backface culling.