Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace travis with github actions #290

Merged

Conversation

inigomarquinez
Copy link
Member

This PR migrates the CI from travis to GitHub actions (agreed to migrate to GH actions here)

@UlisesGascon, the project would need to be removed from travis

The new ci action and README.md changes are based on the respective files in cookie repository

Action passing at my fork

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon UlisesGascon merged commit efd6bff into expressjs:master May 14, 2024
@UlisesGascon
Copy link
Member

The new pipeline works as expected, see for more details.

@UlisesGascon
Copy link
Member

I was not able to remove the project from Travis, maybe @wesleytodd can do the magic? https://app.travis-ci.com/github/expressjs/morgan

@wesleytodd
Copy link
Member

I do have access to the administrative parts, but I am not sure what to do. I have not really used travis in so long I don't think I have ever seen this UI for managing things. I checked "off" the "build branches" and "build prs". Is that enough?

@inigomarquinez inigomarquinez deleted the ci/migrate-travis-to-gh-actions branch May 16, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants