Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL (SAST) #5433

Merged
merged 7 commits into from
Apr 17, 2024
Merged

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Feb 2, 2024

Main Changes

This change include the addition of CodeQL as the SAST tool for the project. It will run an analysis every day (200fa10)

Impact in the OSSF Scorecard

Screenshot 2024-02-02 at 16 56 32

Context

Changes related

Team discussion related

Changelog

@UlisesGascon UlisesGascon changed the title Add codeql (SAST) Add CodeQL (SAST) Feb 2, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@UlisesGascon UlisesGascon marked this pull request as ready for review February 2, 2024 15:59
Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested latest versions of pinned dependencies

.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
UlisesGascon and others added 4 commits April 17, 2024 11:56
Co-authored-by: Íñigo Marquínez Prado <[email protected]>
Co-authored-by: Íñigo Marquínez Prado <[email protected]>
Co-authored-by: Íñigo Marquínez Prado <[email protected]>
Co-authored-by: Íñigo Marquínez Prado <[email protected]>
@UlisesGascon
Copy link
Member Author

I applied your suggestions @inigomarquinez. I will love to have one approval before merging it (cc: @expressjs/express-tc ) so we can review the suggestions (if any) on the source code 👍

Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes and discussion

.github/workflows/codeql.yml Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UlisesGascon UlisesGascon merged commit 26e53f0 into expressjs:master Apr 17, 2024
26 checks passed
@UlisesGascon UlisesGascon deleted the tools/add-codeql branch April 17, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants