Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Completing the useFocusEffect doc example #28823

Merged
merged 2 commits into from
May 20, 2024

Conversation

kimchouard
Copy link
Contributor

Why

To be as exhaustive as the react-navigation equivalent

How

Added the return () => {} function to the useFocusEffect example, to show how to trigger code when view gets out of focus.

Test Plan

N/A

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label May 14, 2024
@amandeepmittal amandeepmittal changed the title Completing the useFocusEffect doc example [docs] Completing the useFocusEffect doc example May 20, 2024
Copy link
Member

@amandeepmittal amandeepmittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this example @kimchouard!

Congratulations on your first contribution 🎉

I'm just going to make a small change to the log message to make it more meaningful and then merge this PR.

docs/pages/router/reference/hooks.mdx Outdated Show resolved Hide resolved
@amandeepmittal amandeepmittal merged commit 20949af into expo:main May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants