[tracking-transparency][ios] Fix requestTrackingPermissionsAsync being resolved before user makes a choice
#28751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
expo-bot
reviewed
May 10, 2024
| @@ -8,6 +8,8 @@ | |||
|
|
|||
| ### 🐛 Bug fixes | |||
|
|
|||
| - Fix `requestTrackingPermissionsAsync` being resolved instantly due to iOS 17.4 bug | |||
There was a problem hiding this comment.
Suggested change
| - Fix `requestTrackingPermissionsAsync` being resolved instantly due to iOS 17.4 bug | |
| - Fix `requestTrackingPermissionsAsync` being resolved instantly due to iOS 17.4 bug ([#28751](https://github.com/expo/expo/pull/28751) by [@behenate](https://github.com/behenate)) |
|
The Pull Request introduced fingerprint changes against the base commit: 060e01d Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-tracking-transparency/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "177aa100d9fd18cdf3c29b31dbd0bd94cb2b33e6"
}
]Generated by PR labeler 🤖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
On iOS 17.4
requestTrackingPermissionsAsyncwill resolve instantly (even before the modal is shown) with statusdenieddue to a known bug (in our case it wasundetermineddue to implementation differences).How
Used a workaround which detects if the bug has appeared. In that case promise is stored until the app returns to foreground - that's when user has made a choice in the modal. After the app has returned to foreground we can call requestPermissions again to get the correct result.
Test Plan
Tested in iOS 17.4 simulator in BareExpo