Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sensors][Android] Remove usage of InternalModule #28715

Merged
merged 4 commits into from
May 20, 2024

Conversation

lukmccall
Copy link
Contributor

Why

Removes usage of InternalModule in the expo-sensor package.
That change made the code more readable, in my opinion.

How

We are currently migrating from an old module API. All Android modules have successfully switched to the new API to export functonality to JS. However, some parts remain untouched and still utilize the unimodules infrastructure.

Test Plan

  • bare-expo ✅

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 9, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented May 9, 2024

The Pull Request introduced fingerprint changes against the base commit: 76c2f01

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-modules-core",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "ce9cca987470dc6cd44c831ca843b83fdd045ee6"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-sensors/android",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "b438a52ec63758b613527478f4aaf1b652fab086"
  }
]

Generated by PR labeler 🤖

@lukmccall lukmccall requested a review from Kudo as a code owner May 9, 2024 12:05
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but please wait until brent start to publish packages from sdk-51 before merge.

@lukmccall lukmccall force-pushed the @lukmccall/sensors/remove-internal-module branch from 7b6fe96 to cbbdb8b Compare May 20, 2024 13:49
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against a0fc381

@lukmccall lukmccall merged commit 88d6feb into main May 20, 2024
3 checks passed
@lukmccall lukmccall deleted the @lukmccall/sensors/remove-internal-module branch May 20, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants