Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): test watchman for e2e cli tests #28605

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented May 3, 2024

Why

See if we get any performance boost out of the cli e2e tests with watchman, specifically, the export tests.

How

  • Disabled cli e2e sharding
  • Installed watchman for cli e2e tests

Test Plan

See GitHub Actions.

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label May 3, 2024
@byCedric byCedric force-pushed the @bycedric/research/cli-e2e-watchman-improvements branch from 6d576b5 to 024c744 Compare May 3, 2024 13:54
@byCedric byCedric force-pushed the @bycedric/research/cli-e2e-watchman-improvements branch from 024c744 to 5c498fa Compare May 3, 2024 13:54
@expo-bot
Copy link
Collaborator

expo-bot commented May 3, 2024

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 33065af

@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions and removed bot: passed checks ExpoBot has nothing to complain about labels May 3, 2024
@byCedric
Copy link
Member Author

byCedric commented May 3, 2024

lmao @EvanBacon. This is not feasable until we've stopped binding the server for static exports. 8082 might be taken during start-up when not running in the band but still passing the getFreePortAsync check.

Overal time to install watchman is 1m30s/2m. Which isn't fast (enough) for now, will only be faster if we add more e2e tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants