Implement JS-esque StateBase.srcCharCodeAt
#190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces use of
StateBase.srcCharCode
with the more JS-esqueStateBase.srcCharCodeAt
that can returnNone
.I didn't remove
StateBase.srcCharCode
for ease of migration because mdit-py-plugins use it. But did deprecate it.Happy to hear what you think @chrisjsewell . Not sure if this is the solution or migration strategy you want, but it's something 😄
I haven't measured performance yet. We may want to do that if this is something we want to proceed with otherwise
EDIT: This PR is in response to discussion in #186