Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pydantic version #942

Conversation

maciejmajerczyk
Copy link

Issue: #862

Notes:

upgraded pydantic version to allow versions <3
fixed tests in test_pydantic_utils.py yo use _pydantic_compat.py
increased evidently version so we get a new version

@maciejmajerczyk maciejmajerczyk changed the title #862: Bump pydantic version Bump pydantic version Jan 9, 2024
@@ -1,5 +1,5 @@
#!/usr/bin/env python
# coding: utf-8

version_info = (0, 4, 13)
version_info = (0, 4, 14)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's undo these changes. we bump the version ourselves
@maciejmajerczyk

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@DimaAmega
Copy link
Collaborator

DimaAmega commented Jan 11, 2024

Hi @maciejmajerczyk! Thanks for your contribution!

As you can see, there is a failed test

To reproduce the error you should run

evidently ui --port 8000 --demo-projects all

Next go to http://localhost:8000 and see logs in terminal

@mike0sv
Copy link
Collaborator

mike0sv commented Jan 11, 2024

tiangolo/fastapi#10360 - I guess fastapi still doesn't work with pydantic.v1 models :(

@emeli-dral
Copy link
Contributor

Hi @maciejmajerczyk ,
I'm sorry for the late reply.

We discussed the issue with the pydantic version. Indeed this should be addressed immediately and here is an option we could suggest now: as evidently ui service depends of FastAPI we cannot bump pydantic version right now (tiangolo/fastapi#10360). However, if you use evidently to generate Reports or TestSuites only (without running evidently ui) or if you calculate Reports or TestSuites in one environment but run evidently ui service on the other environment you can do the following. It is ok to bump pydantic version after you installed evidently in the environment where you do not need to run evidently ui. Report or TestSuite calculations work just fine with pydantic 2.

We certainly understand that this solution is neither convenient nor stable. This is why we now replace FastAPI with litestar. After this replacement we will be able to bump pydantic version. I believe it will happen in a couple of weeks.

@emeli-dral
Copy link
Contributor

solved in #995 , #1003
package version 0.4.16

@emeli-dral emeli-dral closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants