Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: updated the docker-compose file for modern setups, added supp… #530

Closed
wants to merge 1 commit into from

Conversation

whizps
Copy link

@whizps whizps commented May 12, 2024

Support for swedish language

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x ] Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Swedish Language and a change to the docker configuration since it was outdated if you use a newer version for compose & docker engine

  • Bugfix
  • [x ] Feature
  • Code style update (formatting, local variables)
  • [x ] Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • [ x] Other... Please describe:

What is the current behavior?

Swedish language was missing so added that.

Docker changes: the new docker versions does not use Versions: in their dockerfiles, it has been replaced with "name:" or you can just go without anything, but the old method of using "version" is obsolete

So when you start the container from making changes it gives a warning about versions being obsolete.

docs: https://docs.docker.com/compose/compose-file/04-version-and-name/

Issue Number: N/A

What is the new behavior?

if you use name at the top of the docker file, it now changes the name globally for that "project" so if you have a service called "app" and your name is "evershop" it will then go under the name "evershop_app"

fair warning, this will also screw upp current deployments if you were to update your docker and change to name. so if there is a currently old version using "version 3.x" i would just remove it and start from the services field.

Does this PR introduce a breaking change?

  • [x ] Yes
  • [x ] No

As above, be weary about the "name:" field if you update your docker engine/compose.

Other information

@whizps whizps closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant