Update from System.Data.SqlClient to Microsoft.Data.SqlClient in v0.x #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice and clean PR. 0.x builds aren't working (need help or time to get them up and running again), but I'll try to verify this manually to see if it can be merged. |
|
I've tried to get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in of update in discussion: #1022 (comment)
PR contains minimal set of changes to make transfer to Microsoft.Data.SqlClient successful. Threat warning as errors caused problems for valnerable packages. I've updated only
Newtonsoft.Jsonas this I could test. I didn't have any MongoDB or Owin project to test on, so these are now marked with "NoWarn" option. I could try to update those also, but in this case I'd go with Yurii's PR and update all.