Refactor CI for postgres #3389
Refactor CI for postgres #3389
Conversation
There was a problem hiding this comment.
A commendable effort (it's really weird that the CI builds fail so often, but not always, they seem very slow so they time out).
However:
- This PR removes testing for python 3.10 + postgresql
- The postgresql+3.11 tests added here is still not working in CI.
We test with an old version of Postgres because this is the minimim version supported by Django. If you have any other ideas for how to improve the postgresql tests I'm all ears though!
|
@Griatch the only change worth keeping so far is using postgres by declaring it in services instead of using another action, it should let us provide a conf to postgres more easily, I did research a few ways to make the tests faster, using one or a few parameters mentioned here https://www.postgresql.org/docs/current/non-durability.html However I don't understand why the pg tests would be that slow compared to other databases so I would have to investigate more. |
|
Its on the TODO pile, I'll come back to it 😅 |
|
Ping. :) |
|
@ChrisLR Another ping |
|
@Griatch Still experimenting, unsure why having the two pg tests run in parallel makes one of them fail while one after the other works |
|
@ChrisLR Added Python3.12 to the CI matrix, and the postgres issue remains 😞 |
|
@Griatch using the code from this PR ? :( |
|
Nono, just adding a data point since you were looking at this. |
|
@Griatch 😌 great, so there's a chance this PR is sufficient, I will add 3.12 to it and see |
|
@ChrisLR This is still marked as a Draft. Is this still being worked on? |
|
@Griatch sorry about the delay, yes this is still on my plate. |
# Conflicts: # .github/workflows/github_action_test_suite.yml
|
No longer worked after resolving conflicts. |
Brief overview of PR changes/additions
PSQL tests usually fail after 30 minutes, looking at the actions file I saw the pg version is very outdated.
Motivation for adding to Evennia
Fixing the CI
Other info (issues closed, discussion etc)