Fixed crashes due to unhandeled exception in infrared_id_compensation code #24
Conversation
| for (int u = 0; u < img->image.cols; u++) { | ||
| img->image.at<uchar>(v, u) = | ||
| infrared_compensation_[img->image.at<uchar>(v, u)]; | ||
| try { |
There was a problem hiding this comment.
Prefer specific checks to try blocks where possible. E.g. if the issue is that the messages are sometimes empty you can directly check for that. If it fails for various reasons then try-catch is fine. The entire image conversion loop does not need to be in the try block I think? The only thing that could go wrong here is that the data is out of range, which you can statically check for when loading the infrared corrections (i.e. that all values between 0-255 are covered)
| } | ||
| pub_.publish(img->toImageMsg()); | ||
| } catch (const cv_bridge::Exception& e) { | ||
| std::cerr << "Could not convert image to CvImage\n"; |
There was a problem hiding this comment.
Better to stay consistent with logging (i.e. we use glog throughout the project). Consider replacing with more informative text, e.g. LOG(WARNING) << "Could not convert image for infrared_id_compensation, skipping frame (" << e.what() << ").";
Fixed crash during conversion of corrupt received image data to cv image.