Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add subscribe to logs page #3403

Merged
merged 1 commit into from
May 21, 2024

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented May 20, 2024

What was wrong?

event/log guide lacking mention of subscriptions via persistent connection providers. v1 here; could do with a richer explanation of how to build and scope topics, but will leave for a follow-on PR.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@wolovim wolovim merged commit 5df77f9 into ethereum:main May 21, 2024
71 checks passed
@wolovim wolovim deleted the docs-subscribe-mentions branch May 21, 2024 20:03
fselmo pushed a commit to fselmo/web3.py that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants