Style corrections in Yul Optimizer docs #15053
Conversation
| - SSA Transform | ||
| - Common Subexpression Eliminator | ||
| - Expression Simplifier | ||
| - Unused Assign Eliminator | ||
| - Full Inliner | ||
| - SSATransform | ||
| - CommonSubexpressionEliminator | ||
| - ExpressionSimplifier | ||
| - UnusedAssignEliminator | ||
| - FullInliner |
There was a problem hiding this comment.
This list actually seems out of date. Or is e.g. UnusedStoreRemover or LoadResolver really not a major component?
There was a problem hiding this comment.
Well, arguable - the distinction between "main" components and otherwise is blurry anyways and the UnusedStoreRemover and LoadResolver are rather weak in the sense that they only kick in under rather specific circumstances so far. Meaning: I'd not consider too relevant what we list here. The bigger question is whether the list is helpful at all.
cameel
force-pushed
the
optimizer-docs-style-cleanup
branch
2 times, most recently
from
125225c
to
6702af2
Compare
- Add missing backticks. - Use consistent style for step naming (capitalized, without spaces, without backticks). - Correct minor text errors like missing plurals.
cameel
force-pushed
the
optimizer-docs-style-cleanup
branch
from
6702af2
to
9599d85
Compare
|
I don't really care if they're camel case or normal text either, just that it's only one and used consistently. Otherwise searching for them is annoying (have to do it twice each time) and also when updating docs I'm unnecessarily wasting time wondering which one I should use. |
This is a bit of cleanup that I did while updating optimizer docs. I separated it from the main PR because it makes actual semantic changes harder to see. It should also be much easier to review.
Main corrections: