Fix handling of local assembly variables in ReferencesResolver #14820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was fixed by modifying the handling of local assembly variables in the ReferencesResolver class.
Here's a breakdown of the changes made:
visit
andendVisit
methods forBlock
, the local assembly variables stack is updated to push a new set when entering a block and pop it when leaving a block.yul::Identifier
, the error reporting for undeclared identifiers with_offset
or_slot
suffixes is only triggered if the identifier is not found in the current local assembly variables scope.yul::VariableDeclaration
, the local assembly variables set for the current scope is updated with the new variable before checking for shadowed declarations.Two new test cases were added to verify the correct handling of local assembly variables with
_offset
and_slot
suffixes.This fixes issue #14589