Add a multi committee attestation spec test #3770
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The linting tasks |
mkalinin
reviewed
May 20, 2024
| @@ -105,13 +105,24 @@ def get_valid_attestation(spec, | |||
| if index is None: | |||
| index = 0 | |||
|
|
|||
| attestation_data = build_attestation_data(spec, state, slot=slot, index=index, beacon_block_root=beacon_block_root) | |||
| if isinstance(index, (list, tuple)): | |||
There was a problem hiding this comment.
I think it would be cleaner to have a separate helper that capable of creating multi committee attestations and reuses get_valid_attestation as the underlying call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Lodestar we encounter a scenario for an attestation from multi-committee was failing. This could have identified earlier if we had a spec for this scenario.