Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Export functionality to Import detail page panels #2905

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bhbrunt
Copy link

@bhbrunt bhbrunt commented Nov 20, 2023

Background / Motivation

On the Import detail page there are panels showing the imported, updated and duplicate records associated with that import. It's useful to be able to export these lists for verification purposes.

Export of these lists can currently be (partially) achieved by opening the "View List" modal, clicking the "Select all" checkbox and selecting Export on the dropdown. This has some shortcomings, however:

  • Only the records currently displayed are included in the export, even if many more are present. It is easy to mistakenly think the export includes all records. It is possible to export the entire list, but only by repeatedly clicking "show more" until all records are in view. For a large number of records each reload of the list takes some time.
  • The export option is accessible only from the View List modal, and not directly from the detail page where the panels are displayed.

There is existing functionality to export the list of import errors from the Import detail page, but this is not available for the relationship panels (imported, updated, duplicates).

Description

This pull request implements a CSV export of the records linked to an import.
This adds an "Export" item to the dropdown menu for each panel on the import detail view, in the same style as exists for the import errors list.
The implementation follows the existing functionality for exporting the list of "error" records, and uses the existing CSV export functionality.

image

@yurikuzn
Copy link
Contributor

Thanks for PR. We are currently in a process of creating a new version of our CLA, it's going to be available in a few days.

I'll check this more detail when get a chance. Not yet sure whether we need this functionality though.

A few things I noticed while viewing quick:

  • Espo\Services\Import is not right choice.
  • Indentation problem in some places. Might be your editor/IDE does not honor editorconfig and uses tabs instead spaces.

@bhbrunt
Copy link
Author

bhbrunt commented Nov 21, 2023

Thanks for the first review! I've fixed the indentation problems, now taking account of editorconfig and 4 spaces rather than tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants