Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ESP32 and libretiny use C++17 #6766

Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from
Draft

Conversation

HeMan
Copy link
Contributor

@HeMan HeMan commented May 18, 2024

What does this implement/fix?

Change C++ standard to C++17 for ESP32 and Libretiny

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 54.16%. Comparing base (4d8b5ed) to head (1373b78).
Report is 630 commits behind head on dev.

Files Patch % Lines
esphome/cpp_generator.py 80.00% 1 Missing ⚠️
esphome/writer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6766      +/-   ##
==========================================
+ Coverage   53.70%   54.16%   +0.45%     
==========================================
  Files          50       50              
  Lines        9408     9631     +223     
  Branches     1654     1698      +44     
==========================================
+ Hits         5053     5217     +164     
- Misses       4056     4088      +32     
- Partials      299      326      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants