Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Xextan Language #1881

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

WallFlowerWeed
Copy link

Data for the constructed art language Xextan, adapted for current version of eSpeak-NG.

@WallFlowerWeed WallFlowerWeed marked this pull request as draft March 26, 2024 06:02
@WallFlowerWeed WallFlowerWeed marked this pull request as ready for review March 26, 2024 13:56
@WallFlowerWeed WallFlowerWeed marked this pull request as draft March 29, 2024 04:00
@WallFlowerWeed WallFlowerWeed marked this pull request as ready for review April 21, 2024 11:13
@jaacoppi
Copy link
Collaborator

jaacoppi commented Jun 9, 2024

Looks good. Things to do before approval:

add a commit to update ChangeLog.md to include this new language
update your branch to solve the "This branch is out-of-date with the base branch" warning.

@jaacoppi
Copy link
Collaborator

jaacoppi commented Jun 9, 2024

Also: include the language in the windows build files in src/windows as well

@WallFlowerWeed
Copy link
Author

I believe the branch is ready for inspection. Do let me know if I've missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants