Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade [email protected] dev dependency #18332

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Updates dev dependency globals to v15.

What changes did you make? (Give an overview)

  • Updated package.json
  • Since the Intl global is now enabled by default in ES2015+, but not explicitly in the set of browser globals, I updated a few tests accordingly.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels Apr 13, 2024
@mdjermanovic mdjermanovic requested a review from a team as a code owner April 13, 2024 15:26
Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit d67fe36
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/661ad8a6076b3d0008584c07
😎 Deploy Preview https://deploy-preview-18332--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fasttime
Copy link
Member

Shall we also remove the /*global Intl*/ comments from the rule examples of no-obj-calls?

@mdjermanovic
Copy link
Member Author

Shall we also remove the /*global Intl*/ comments from the rule examples of no-obj-calls?

Good idea! Removed in d67fe36

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 4820790 into main Apr 13, 2024
19 checks passed
@fasttime fasttime deleted the globals-15.0.0 branch April 13, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants