Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mention package.json config support dropped #18305

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Apr 9, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added a note in the configuration migration guide that package.json configs are no longer supported.

fixes #18296

Is there anything you'd like reviewers to focus on?

Is there any place else that would make sense to mention this?

@nzakas nzakas requested a review from a team as a code owner April 9, 2024 18:39
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 9, 2024
Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit e7a9110
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/66158b5d749edf000892bb67
😎 Deploy Preview https://deploy-preview-18305--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snitin315 snitin315 merged commit 113f51e into main Apr 10, 2024
19 checks passed
@snitin315 snitin315 deleted the issue18296 branch April 10, 2024 03:18
@mahnunchik
Copy link

I won't upgrade to version 9 without support "eslintConfig" key in package.json 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: package.json eslintConfig no longer functions
4 participants