docs: mention about name field in flat config
#18252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nzakas
requested changes
Apr 1, 2024
Co-authored-by: Nicholas C. Zakas <[email protected]>
Co-authored-by: Nicholas C. Zakas <[email protected]>
antfu
commented
Apr 1, 2024
1 task
Tanujkanti4441
previously requested changes
Apr 2, 2024
Co-authored-by: Tanuj Kanti <[email protected]>
nzakas
reviewed
Apr 2, 2024
Co-authored-by: Nicholas C. Zakas <[email protected]>
mdjermanovic
reviewed
Apr 3, 2024
mdjermanovic
reviewed
Apr 3, 2024
Comment on lines
+355
to
+360
| recommended: { | ||
| name: "example/recommended", | ||
| rules: { | ||
| "no-unused-vars": "warn" | ||
| } | ||
| }, |
There was a problem hiding this comment.
What would be the convention if the configuration is an array of configuration objects? Would it be the same name for all configuration objects?
There was a problem hiding this comment.
Good point! I mentioned it here 8cccc58
Supposely the config inspector could have an indicator of duplicated names to help with that as well.
Co-authored-by: Milos Djermanovic <[email protected]>
nzakas
previously approved these changes
Apr 3, 2024
Co-authored-by: Nicholas C. Zakas <[email protected]>
Closed
4 tasks
aladdin-add
added a commit
to eslint-community/eslint-plugin-eslint-plugin
that referenced
this pull request
Apr 8, 2024
aladdin-add
added a commit
to eslint-community/eslint-plugin-n
that referenced
this pull request
Apr 8, 2024
aladdin-add
added a commit
to eslint-community/eslint-plugin-n
that referenced
this pull request
Apr 8, 2024
aladdin-add
added a commit
to eslint-community/eslint-plugin-n
that referenced
this pull request
Apr 8, 2024
aladdin-add
added a commit
to eslint-community/eslint-plugin-n
that referenced
this pull request
Apr 8, 2024
* feat: add `name` to flat configs refs: eslint/eslint#18252 * fix: npm install error
aladdin-add
added a commit
to eslint-community/eslint-plugin-eslint-plugin
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
What changes did you make? (Give an overview)
Resolves #18231
This PR updates the docs for flat config, mentioning the
nameproperty. Recommending people to provide that field with a convention to have/as the separator (consistent with how rules are composed).Is there anything you'd like reviewers to focus on?