fix: only ignore top-level test case properties

eslint · Mar 28, 2024 · 56d7198 · 56d7198
1 parent e62558d
commit 56d7198
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/rule-tester/rule-tester.js b/lib/rule-tester/rule-tester.js
@@ -873,7 +873,13 @@ class RuleTester {
  }
 
  const normalizedItem = typeof item === "string" ? { code: item } : item;
- const serializedTestCase = stringify(normalizedItem, { replacer: (key, value) => (!duplicationIgnoredParameters.has(key) ? value : void 0) });
+ const serializedTestCase = stringify(normalizedItem, {
+ replacer(key, value) {
+
+ // "this" is the currently stringified object --> only ignore top-level properties
+ return (normalizedItem !== this || !duplicationIgnoredParameters.has(key)) ? value : void 0;
+ }
+ });
 
  assert(
  !seenTestCases.has(serializedTestCase),

diff --git a/tests/lib/rule-tester/rule-tester.js b/tests/lib/rule-tester/rule-tester.js
@@ -3195,6 +3195,18 @@ describe("RuleTester", () => {
  }, "detected duplicate test case");
  });
 
+ it("does not ignore top level test case properties nested in other test case properties", () => {
+ ruleTester.run("foo", {
+ meta: { schema: [{ type: "object" }] },
+ create() {
+ return {};
+ }
+ }, {
+ valid: [{ options: [{ name: "foo" }], name: "foo", code: "same" }, { options: [{ name: "bar" }], name: "bar", code: "same" }],
+ invalid: []
+ });
+ });
+
  it("does not throw an error for defining the same test case in different run calls", () => {
  const rule = {
  meta: {},