fix: correct hasUnsafeRefsInNonIIFE logic

eslint · Jan 1, 2024 · 0fd38e9 · 0fd38e9
1 parent 36814ac
commit 0fd38e9
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/lib/rules/no-loop-func.js b/lib/rules/no-loop-func.js
@@ -214,17 +214,17 @@ module.exports = {
 
  // Check if there are unsafe references used within non-immediately-invoked nested functions
  const hasUnsafeRefsInNonIIFE = unsafeRefs.some(r => {
- let refFunctionNode = r.from.variableScope.block;
+ let refScope = r.from.variableScope;
 
- if (node === refFunctionNode) {
- return !isIIFE(refFunctionNode);
+ if (node === refScope.block) {
+ return !isIIFE(refScope.block);
  }
 
- while (node !== refFunctionNode) {
- if (!isIIFE(refFunctionNode)) {
+ while (node !== refScope.block) {
+ if (!isIIFE(refScope.block)) {
  return true;
  }
- refFunctionNode = refFunctionNode.parent;
+ refScope = refScope.upper.variableScope;
  }
 
  return false;