Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch to eslint flat config #121

Merged
merged 2 commits into from Mar 18, 2024
Merged

refactor: switch to eslint flat config #121

merged 2 commits into from Mar 18, 2024

Conversation

mdjermanovic
Copy link
Member

Switches to using eslint.config.js when linting this project.

Some notable changes:

  • Upgrades to latest eslint v8 and eslint-config-eslint v9.
  • Config files (eslint.config.js and rollup.config.js) and tests/util files are now also linted.
  • Adds eslint-plugin-chai-friendly to replace no-unused-expressions in test files.
  • eslint is now run directly instead of through Makefile.js.

Marked as "refactor" because there are few changes in the production code.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit 59b1606 into main Mar 18, 2024
10 checks passed
@nzakas nzakas deleted the flat-config branch March 18, 2024 18:32
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants