Fix mod_event_pusher_push MUC Light error #3526
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a stanza was addressed to a room, there were errors in the logs due to a failed hook
filter_local_packet
running withTo
being the sender (mod_event_pusher:push_event/3
failed on the ETS lookup, because the name was expecting a Host, not a MUC Light host). The problem originates from the fact, thatfilter_local_packet
is called twice when processing a MUC Light message (see the comment).From what I understand, this change would mean that the notification will be processed (maybe tried to be sent?) in the context of the room - "to" the room itself.