New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showing output automatically upon completion and animated icon #578
base: master
Are you sure you want to change the base?
Conversation
@gseguinbourgeois
but... |
@gseguinbourgeois ping |
I tried looking at the code to understand why and when the little loading icon changed color. Not sure it has to do with salt events. I am always running commands from the commandline and I tried using --async. I am not sure what good it brings. Thanks for your replies. |
@gseguinbourgeois
That piece of code is part of function With all that information combined there are now 2 solutions available: Currently, I'm thinking of using (A) with a fixed interval of 5 seconds when used. A play/stop button will be added to the relevant screens. The timer will be cancelled when the job (or all jobs) are finished. The state of the play/stop button will be remembered within the session. So only the first time you need to activate it. I've converted this issue into a (still empty) PR. You'll see some code appear there later. I may ask you a few times to try it. |
Thank you for taking the time to give all this information. Option A seems to answer the need even though we know an event based solution would be cleaner. I will be following this with much excitement! |
12d18e6
to
62a0021
Compare
There are a few places where jobs are handled:
|
@gseguinbourgeois please let me know whether this is the intended behavior and whatever suggestions you still have for this. |
@gseguinbourgeois While working on this, I found a general problem in SaltGUI for the use of timers. (again:) please let me know whether this is the intended behavior and whatever suggestions you still have for this. |
d861c09
to
3178f4e
Compare
@gseguinbourgeois |
1a8ac4b
to
3178f4e
Compare
3178f4e
to
849d247
Compare
Quality Gate passedIssues Measures |
(note for historic purposes)
In SaltGUI we hardly use any images and characters do not rotate.
|
Is your feature request related to a problem? Please describe.
I find it annoying when I'm waiting for a state/highstate to complete but all I get is a little reload icon color to see if it's done.
Describe the solution you'd like
I think the arrow icon should rotate or be animated when running and then, instead of changing to green or red based on the result, it should simply display the output automatically without having to click on it...
Describe alternatives you've considered
Any kind of animated icon that shows it is still in progress, but for showing the output, I don't see why it wouldn't be that way. There is a callback making the icon change color so it should probably be simple enough to make the call to show the output. Something that is always wanted.
It could be an option in the advanced section as well to please everyone.
Additional context
I'm using SaltGUI on a lot of minions and the less click I do, the happier I am! This is clearly a polishing feature, but those features could make this tool production ready.
Thanks a lot!