Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multiple and redundant track flags #1160

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

dzumii
Copy link
Contributor

@dzumii dzumii commented Jun 14, 2024

Description

Remove multiple, redundant tracking flags and keep a single boolean flag with a default false value, such that by default we do not track runs for now.

Changes to be made

Change the track_serve flag to track and ensure it tracks the session without the need to use track_run again.
Remove the track_run flag
Compare the output with the output of the former state.

Status
Successfully changed the multiple track flags into one (track)
track flag has been moved to serve

To do
Confirm that the metrics of several run sessions of the same model are appended to the same file

Related to #1158 #1090

@dzumii
Copy link
Contributor Author

dzumii commented Jun 14, 2024

Hello @DhanshreeA
I've been able to remove redundant track flags. Now, users only have to use the track flag at the point of serving the model alone and don't need to use it for every model run. Also, I confirmed the metrics for each run are saved to the same session file. For example, I ran the model six times with different inputs, and the metrics for the six runs are in the txt file.

ersilia/core/session.py Outdated Show resolved Hide resolved
ersilia/core/session.py Outdated Show resolved Hide resolved
ersilia/core/model.py Outdated Show resolved Hide resolved
ersilia/core/model.py Outdated Show resolved Hide resolved
ersilia/core/model.py Outdated Show resolved Hide resolved
ersilia/core/session.py Outdated Show resolved Hide resolved
@DhanshreeA
Copy link
Member

@dzumii LGTM, requesting few minor changes.

@DhanshreeA DhanshreeA merged commit 0a17f9b into ersilia-os:master Jun 17, 2024
16 checks passed
@dzumii dzumii deleted the remove-redundant-flags branch June 23, 2024 15:02
@dzumii dzumii restored the remove-redundant-flags branch June 23, 2024 15:02
@dzumii dzumii deleted the remove-redundant-flags branch June 23, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants